Remove unnecessary relative root #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated paths always had a hardcoded `./` prefix. This resulted in paths like this: `import IWow from './../foo/bar/IWow';` While technically correct, the initial `./` is redundant, and looks a bit silly. I've removed the hardcoded `./` and added a check for the first character of the relative path being a `.`. This means it will not be added, unless the import is for a file in the same directory as the source file, in which case it will result in `./IWow`
|
Hey, sorry for the long delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated paths always had a hardcoded
./prefix. This resulted inpaths like this:
import IWow from './../foo/bar/IWow';While technically correct, the initial
./is redundant, and looks abit silly.
I've removed the hardcoded
./and added a check for the firstcharacter of the relative path being a
.. This means it will not beadded, unless the import is for a file in the same directory as the
source file, in which case it will result in
./IWow